Re: [bug-diffutils] Building diffutils 3.3 with hardening flags

[Santiago Vila]

On Mon, 12 Aug 2013, Paul Eggert wrote:

> Santiago Vila wrote:
> > Almost. This is what works for me:
> > 
> > --- a/gnulib-tests/test-xvasprintf.c
> > +++ b/gnulib-tests/test-xvasprintf.c
> > @@ -95,7 +95,7 @@
> >    {
> >      /* Silence gcc warning about zero-length format string.  */
> >      const char *empty = "";
> > -    result = xasprintf (empty);
> > +    result = xasprintf (empty, empty);
> 
> Now I'm confused, since that patch doesn't apply to
> diffutils 3.3, which is what the subject line was
> talking about.  Is this an older diffutils?  If so,
> perhaps the bug's fixed upstream already.  Or maybe
> it's some Debian patch that needs unpatching.

I have double-checked and the patch applies cleanly to diffutils 3.3
as retrieved from the canonical place:

http://ftp.gnu.org/gnu/diffutils/diffutils-3.3.tar.xz

Are you trying to apply the patch to the git version?