Re: [bug-gawk] Increased RAM memory usage in gawk 5.0.1 compared to gawk 4.1.4

[Andrew J. Schorr]

On Wed, Aug 28, 2019 at 06:46:27PM -0400, Andrew J. Schorr wrote:
> In particular, this code in Op_push_re is worrisome:
> 
>                 case Op_push_re:
>                         m = pc->memory;
>                         if (m->type == Node_dynregex) {
>                                 r = POP_STRING();
>                                 unref(m->re_exp);
>                                 m->re_exp = r;
> 
> So that follows the pattern of calling unref before assigning.
> This may be the only other place that assigns to m->re_exp.
> Perhaps re_exp is always NULL at this point. Actually, that's not
> true -- I inserted a printf, and there are many cases in "make check"
> where re_exp is non-NULL there.
> 
> So I am concerned...

OK. On 3rd thought, I think the attached patch fixes the problem and
is safer than the 1st version. I think this one is a winner.

Regards,
Andy

dynregex.field.patch
Description: Text document