[bug #63371] build fails on MinGW due to missing gnulib close module

[Vaclav Slavik]

URL:
  <https://savannah.gnu.org/bugs/?63371>

                 Summary: build fails on MinGW due to missing gnulib close
module
                 Project: GNU gettext
               Submitter: vslavik
               Submitted: Tue 15 Nov 2022 06:15:05 PM UTC
                Category: Build
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Tue 15 Nov 2022 06:15:05 PM UTC By: Vaclav Slavik <vslavik>
I'm seeing build failures in up-to-date MSYS2 environment when trying to build
0.21.1.



D:/a/_temp/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe:
.libs/libgettextsrc_la-write-catalog.o:write-catalog.:(.text+0x6e4): undefined
reference to `close_used_without_requesting_gnulib_module_close'
5766
collect2.exe: error: ld returned 1 exit status
5767
make[4]: *** [Makefile:3782: libgettextsrc.la] Error 1
5768
make[4]: Leaving directory
'/d/a/gettext-tools-windows/gettext-tools-windows/build/compile/gettext-0.21.1/gettext-tools/src'
5769
make[3]: *** [Makefile:3629: all] Error 2


(Eventually, more files that use close() would be affected (msgexec.c,
msggrep.c, urlget.c, write-catalog.c), this is just the first failure.)

I _think_ this patch, which adds close to GNULIB_MODULES_TOOLS_FOR_SRC, is
sufficient to fix:


diff --git a/autogen.sh b/autogen.sh
index b896c3f1e..02a5fe130 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -134,6 +134,7 @@ if ! $skip_gnulib; then
     c-strcasestr
     c-strstr
     clean-temp
+    close
     closedir
     closeout
     configmake


But I have difficulty successfully running "make dist" here to be able to test
it, and all the relevant files are generated and not included in git. 







    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63371>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/