Fwd: Bug#1018950: gettext-el: warnings when po-mode.el is compiled with GNU Emacs 28

[Santiago Vila]

Hello.

Some time ago I received this report from Vincent Lefevre regarding po-mode.
The problem seems not to be fixed in the current version.

I include below a summary of the issue. The full history may be found here:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1018950

Thanks.
-----------------------------------
From: Vincent Lefevre <vincent@vinc17.net>

[...]

On my Debian/unstable machine, I've downgraded the emacs packages
to stable with

  aptitude install emacs-gtk/stable emacs-bin-common/stable emacs-common/stable 
emacs-el/stable

(thus to GNU Emacs 28.2), and... I can now see the warnings:

Warning (comp): po-mode.el:1068:14: Warning: ‘write-contents-hooks’ is an 
obsolete variable (as of 22.1); use ‘write-contents-functions’ instead. Disable 
showing Disable logging
Warning (comp): po-mode.el:2113:2: Warning: (lambda nil \.\.\.) quoted with ' 
rather than with #' Disable showing Disable logging
Warning (comp): po-mode.el:2569:37: Warning: ‘goto-line’ is for interactive use 
only; use ‘forward-line’ instead. Disable showing Disable logging
Warning (comp): po-mode.el:2639:10: Warning: ‘tags-loop-continue’ is an 
obsolete function (as of 27.1); use ‘fileloop-continue’ instead. Disable 
showing Disable logging
Warning (comp): po-mode.el:2642:13: Warning: ‘tags-loop-continue’ is an 
obsolete function (as of 27.1); use ‘fileloop-continue’ instead. Disable 
showing Disable logging
Warning (comp): po-mode.el:2706:36: Warning: Use ‘with-current-buffer’ rather 
than save-excursion+set-buffer Disable showing Disable logging
Warning (comp): po-mode.el:2735:35: Warning: Use ‘with-current-buffer’ rather 
than save-excursion+set-buffer Disable showing Disable logging
Warning (comp): po-mode.el:2110:4: Warning: the function ‘ediff-quit’ is not 
known to be defined. Disable showing Disable logging

So, the bug is not fixed in gettext-el.

I can actually see warnings in the Async-native-compile-log buffer
with GNU Emacs 29 (current Debian/unstable version); see below. So,
what has changed is that Emacs now hides the warnings.

In short:
  * GNU Emacs 28 shows annoying warnings. This should be regarded
    as a bug, but this will probably be never fixed in this version
    for Debian/stable (and Debian/unstable is not affected as it
    has GNU Emacs 29), so I don't think that it is useful to clone
    the bug.
  * The warnings are still present (but hidden), so that the bug is
    actually not fixed. Since GNU Emacs 29 hides them, I've lowered
    the severity to minor.

Here are the details of the warnings (note that the compilation of
the other .el files does not yield any warning; this is specific
to po-mode.el):

In toplevel form:
po-mode.el:180:2: Warning: custom-declare-variable `po-highlight-face' 
docstring has wrong usage of unescaped single quotes (use \= or different 
quoting)
po-mode.el:473:2: Warning: custom-declare-variable `po-gzip-uuencode-command' 
docstring has wrong usage of unescaped single quotes (use \= or different 
quoting)
po-mode.el:503:2: Warning: docstring has wrong usage of unescaped single quotes 
(use \= or different quoting)

In po-create-overlay:
po-mode.el:556:2: Warning: docstring has wrong usage of unescaped single quotes 
(use \= or different quoting)
po-mode.el:843:2: Warning: defvar `po-auxiliary-cursor' docstring has wrong 
usage of unescaped single quotes (use \= or different quoting)

In po-mode:
po-mode.el:1013:2: Warning: docstring has wrong usage of unescaped single 
quotes (use \= or different quoting)
po-mode.el:1068:14: Warning: ‘write-contents-hooks’ is an obsolete variable (as 
of 22.1); use ‘write-contents-functions’ instead.

In po-set-msgid:
po-mode.el:1812:2: Warning: docstring has wrong usage of unescaped single 
quotes (use \= or different quoting)

In po-set-msgstr-form:
po-mode.el:1831:2: Warning: docstring has wrong usage of unescaped single 
quotes (use \= or different quoting)
po-mode.el:2114:13: Warning: (lambda nil \...) quoted with ' rather than with #'

In po-edit-string:
po-mode.el:2238:2: Warning: docstring has wrong usage of unescaped single 
quotes (use \= or different quoting)

In po-seek-equivalent-translation:
po-mode.el:2408:2: Warning: docstring has wrong usage of unescaped single 
quotes (use \= or different quoting)

In po-cycle-auxiliary:
po-mode.el:2449:2: Warning: docstring has wrong usage of unescaped single 
quotes (use \= or different quoting)

In po-select-auxiliary:
po-mode.el:2486:2: Warning: docstring has wrong usage of unescaped single 
quotes (use \= or different quoting)

In po-show-source-context:
po-mode.el:2570:4: Warning: ‘goto-line’ is for interactive use only; use 
‘forward-line’ instead.

In po-tags-search:
po-mode.el:2639:10: Warning: ‘tags-loop-continue’ is an obsolete function (as 
of 27.1); use ‘fileloop-continue’ instead.
po-mode.el:2643:8: Warning: ‘tags-loop-continue’ is an obsolete function (as of 
27.1); use ‘fileloop-continue’ instead.

In po-tags-loop-operate:
po-mode.el:2703:12: Warning: Use ‘with-current-buffer’ rather than 
save-excursion+set-buffer

In po-mark-found-string:
po-mode.el:2724:6: Warning: Use ‘with-current-buffer’ rather than 
save-excursion+set-buffer

In po-validate:
po-mode.el:3185:2: Warning: docstring has wrong usage of unescaped single 
quotes (use \= or different quoting)

In po-msgfmt-version-check:
po-mode.el:3212:2: Warning: docstring has wrong usage of unescaped single 
quotes (use \= or different quoting)

In end of data:
po-mode.el:2110:4: Warning: the function ‘ediff-quit’ is not known to be 
defined.

--
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)