[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Possible off by one error at crypt/md5-crypt.c:182
From: |
Ulrich Drepper |
Subject: |
Re: Possible off by one error at crypt/md5-crypt.c:182 |
Date: |
30 Aug 2001 18:38:43 -0700 |
User-agent: |
Gnus/5.0807 (Gnus v5.8.7) XEmacs/21.2 (Thelxepeia) |
Ryan Mack <address@hidden> writes:
> Like 182 incorrectly subtracts *four* bytes (sizeof (md5_salt_prefix) = 4)
> from the remaining length of the buffer. *Untested* patch attached
> (sorry, I don't have a system I can test on).
Yes, this is correct. It's nothing really severe since the only
consequence is that the function might fail if it wouldn't have to.
But there was another potentially more problematic problem which I've
fixed.
Thanks,
--
---------------. ,-. 1325 Chesapeake Terrace
Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA
Red Hat `--' drepper at redhat.com `------------------------