Re: portability patch for io/ftw.c

[Ulrich Drepper]

> IMHO, we shouldn't have to make such
> exceptions and litter otherwise-clean code with cpp conditionals
> involving _LIBC.  end of rant :-)

???  Of course we need these _LIBC exceptions.  I'm not going to add all
the HAVE_* macros.  That's just calling for problems.


> If you can point to such a system, please let everyone know.
> That code has been used in the GNU tools I maintain for a long
> time, without causing any problems, afaik.

I fortunately don't have to use any non-Linux system.  Maybe all these
legacy systems died the dead they deserved.


> As for being optimal, there may be a few proprietary systems on which
> the strlen is not strictly necessary, but I don't want to spend my
> time finding them and optimizing this code to accommodate them.

Well, the case also is important if your configure script decides to not
use the built-in nftw from glibc on Linux.  The old libc should of
course be updated but if this happens after compiling coreutils you're
stuck with the inefficient nftw.


Anyway, I've applied the patch since none of this really matters for glibc.

-- 
--------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------