MIPS build fails with assembler errors in rtld.c [was]Re: Glibc bug reports being marked as duplicates...

[David Daney]

Roland McGrath wrote:
>>You marked this as a duplicate:
>>
>>http://sources.redhat.com/bugzilla/show_bug.cgi?id=385
>>
.
.
.
> 
> There isn't much I can do about that.  All I can do is try to make clear
> how you can go about contributing in a way that is useful to the community
> and does not consume the time of other volunteers in excess of that utility.

Sorry I got steamed at the bugzilla issue.

I don't have time to debug the bug submittal process so do with this as you all
see fit.  If you don't want the patch I will keep maintaining it locally.

This is what the glibcbug script seems to produce for me:


This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its
recipients. This is a permanent error. The following address(es) failed:

  pipe to | /usr/lib/gnats/queue-pr -q
    generated by address@hidden
    (ultimately generated from address@hidden)
    local delivery failed

------ This is a copy of the message, including all the headers. ------

Return-path: <address@hidden>
Received: from monty-python.gnu.org ([199.232.76.173])
        by fencepost.gnu.org with esmtp (Exim 4.34)
        id 1C7d3G-0006AC-Kg
        for address@hidden; Wed, 15 Sep 2004 12:54:43 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34)
        id 1C7d37-0004Ql-HD
        for address@hidden; Wed, 15 Sep 2004 12:54:30 -0400
Received: from [216.102.217.178] (helo=avtrex.com)
        by monty-python.gnu.org with esmtp (Exim 4.34)
        id 1C7d36-0004Qf-JJ
        for address@hidden; Wed, 15 Sep 2004 12:54:28 -0400
Received: from avtrex.com ([192.168.0.111] RDNS failed) by avtrex.com with 
Microsoft SMTPSVC(5.0.2195.6713);
         Wed, 15 Sep 2004 09:54:27 -0700
Message-ID: <address@hidden>
Date: Wed, 15 Sep 2004 09:54:27 -0700
From: David Daney <address@hidden>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.1) Gecko/20031030
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: address@hidden
Subject: MIPS build failure with assembler errors in build of rtld.c
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 15 Sep 2004 16:54:27.0449 (UTC) 
FILETIME=[A9592690:01C49B44]
X-Spam-Status: No, hits=0.4 required=5.0
        tests=RCVD_IN_ORBS,USER_AGENT_MOZILLA_UA,X_ACCEPT_LANG
        version=2.55
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)


>>Submitter-Id:  net
>>Originator:    David Daney
>>Organization:

 Avtrex

>>Confidential:  no
>>Synopsis:      MIPS build fails with assembler errors in rtld.c
>>Severity:      critical
>>Priority:      high
>>Category:      libc
>>Class:         sw-bug
>>Release:       libc-2.3.3
>>Environment:

        mips 4Kc, linux 2.4.25
Host type: mipsel-unknown-linux-gnu
System: Linux (none) 2.4.25-Avtrex #147 Tue Sep 7 09:54:54 PDT 2004 mips
unknownArchitecture: MIPS o32 ABI

Addons: linuxthreads
Build CFLAGS: -g -O2
Build CC: mipsel-linux-gcc
Compiler version: 3.3.1
Kernel headers: 2.4.25-Avtrex
Symbol versioning: yes
Build static: yes
Build shared: yes
Build pic-default: yes
Build profile: yes
Build omitfp: no
Build bounded: no
Build static-nss: no


>>Description:

        Assembler errors in build of rtld.c.

>>How-To-Repeat:

../glibc-2.3.3/configure --build=i686-linux --host=mipsel-linux
--enable-add-ons=linuxthreads --prefix=/usr
 mipsel-linux-gcc is GCC-3.3.1
binutils are 2.15


make
.
.
.mipsel-linux-gcc -mabi=32 rtld.c -c -std=gnu99 -O2 -Wall -Winline
-Wstrict-prototypes -Wwrite-strings -g   -fPIC    -I../include -I.
-I/newdisk/programs/mipsel-glibc233/elf -I.. -I../libio
-I/newdisk/programs/mipsel-glibc233 -I../sysdeps/mips/elf
-I../linuxthreads/sysdeps/unix/sysv/linux/mips
-I../linuxthreads/sysdeps/unix/sysv/linux -I../linuxthreads/sysdeps/pthread
-I../sysdeps/pthread -I../linuxthreads/sysdeps/unix/sysv
-I../linuxthreads/sysdeps/unix -I../linuxthreads/sysdeps/mips
-I../sysdeps/unix/sysv/linux/mips/mips32 -I../sysdeps/unix/sysv/linux/mips
-I../sysdeps/unix/sysv/linux -I../sysdeps/gnu -I../sysdeps/unix/common
-I../sysdeps/unix/mman -I../sysdeps/unix/inet -I../sysdeps/unix/sysv
-I../sysdeps/unix/mips/mips32 -I../sysdeps/unix/mips -I../sysdeps/unix
-I../sysdeps/posix -I../sysdeps/mips/mips32 -I../sysdeps/mips
-I../sysdeps/ieee754/flt-32 -I../sysdeps/ieee754/dbl-64
-I../sysdeps/wordsize-32-I../sysdeps/mips/fpu -I../sysdeps/ieee754
-I../sysdeps/generic/elf
-I../sysdeps/generic  -D_LIBC_REENTRANT -include ../include/libc-symbols.h
-DPIC -DSHARED -DNOT_IN_libc=1 -DIS_IN_rtld=1     -o
/newdisk/programs/mipsel-glibc233/elf/rtld.os -MD -MP -MF
/newdisk/programs/mipsel-glibc233/elf/rtld.os.dt
/tmp/ccefhYhh.s: Assembler messages:
/tmp/ccefhYhh.s:125: Warning: missing .end
/tmp/ccefhYhh.s:157: Warning: No .frame pseudo-op used in PIC code
/tmp/ccefhYhh.s:165: Warning: .end directive without a preceding .ent
directive./tmp/ccefhYhh.s:165: Error: junk at end of line, first
unrecognized
character is `.'
 >Fix:

It seems that binutils 2.15 assembler cannot handle nested functions.
With this patch the build succeeds and the resulting libraries seem to
run with out problems.  I have not runthe test suite yet, but I have
been running lots of software on this build of glib c with no
problems.

Apply this patch:

*** glibc-2.3.3/sysdeps/mips/dl-machine.h~      2003-07-30
23:33:52.000000000 -0700
--- glibc-2.3.3/sysdeps/mips/dl-machine.h       2004-09-13
13:51:59.000000000 -0700
***************
*** 474,480 ****
        " STRINGXP(PTR_LA) " $25, _dl_start_user\n\
        .globl _dl_start_user\n\
        .type _dl_start_user,@function\n\
-       .ent _dl_start_user\n\
  _dl_start_user:\n\
        " STRINGXP(SETUP_GP) "\n\
        " STRINGXV(SETUP_GP64($18,_dl_start_user)) "\n\
--- 474,479 ----
***************
*** 512,519 ****
        " STRINGXP(PTR_LA) " $2, _dl_fini\n\
        # Jump to the user entry point.\n\
        move $25, $17\n\
!       jr $25\n\
!       .end _dl_start_user\n\t"\
        _RTLD_EPILOGUE(ENTRY_POINT)\
        ".previous"\
  );
--- 511,517 ----
        " STRINGXP(PTR_LA) " $2, _dl_fini\n\
        # Jump to the user entry point.\n\
        move $25, $17\n\
!       jr $25\n\t" \
        _RTLD_EPILOGUE(ENTRY_POINT)\
        ".previous"\
  );