[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#19131: Acknowledgement (25.0.50; [PATCH] eww.el: Create simple mode
From: |
Lars Magne Ingebrigtsen |
Subject: |
bug#19131: Acknowledgement (25.0.50; [PATCH] eww.el: Create simple mode to manage eww buffers) |
Date: |
Sun, 07 Dec 2014 20:36:05 +0100 |
User-agent: |
Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) |
Andrey Kotlarski <m00naticus@gmail.com> writes:
Looks good. Could you also document this in the eww manual?
I've got some tiny nit-picks for style.
> + (or buffers-info
> + (error "No eww buffers"))
Don't use `or' for control; use `unless'.
> + (if (eobp)
> + (goto-char (point-min)))
And else-less if statements are usually better as `when' statements.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#19131: Acknowledgement (25.0.50; [PATCH] eww.el: Create simple mode to manage eww buffers),
Lars Magne Ingebrigtsen <=