[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#33205: 26.1; unibyte/multibyte missing in rx.el
From: |
Mattias Engdegård |
Subject: |
bug#33205: 26.1; unibyte/multibyte missing in rx.el |
Date: |
Sat, 29 Dec 2018 11:43:56 +0100 |
29 dec. 2018 kl. 10.23 skrev Eli Zaretskii <eliz@gnu.org>:
>
> First, please provide a ChangeLog-style commit log message describing
> the changes. See CONTRIBUTE for more details.
Done.
> The first line of a doc string should be a single full sentence, and
> it should mention the arguments of the function. Also, the first
> sentence confused me: what do you mean by this part:
>
> "... and, representing ranges, dotted pairs of characters"
>
> Finally, please use the US English convention of leaving 2 spaces
> between sentences in the documentation.
All done.
> This seems to have dropped the validity check which signaled an error
> in the original code? Any reason for that?
Just an oversight; check reinstated.
Thank you; new patch attached.
0001-Handle-raw-bytes-and-LF-in-ranges-in-rx-any-argument.patch
Description: Binary data