[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]
From: |
Drew Adams |
Subject: |
bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] |
Date: |
Tue, 11 Jun 2019 10:19:17 -0700 (PDT) |
> > > [0-9A-Fa-f] still has one advantage: the reader, and the
> > > writer, know exactly which characters are included without looking it up.
> For
> > > example:
> > >
> > > - whether upper case, lower case, or both are accepted
> > > - whether non-ascii digits are accepted (included in [:digit:] on many
> > > platforms)
> >
> > +1. At least the doc for [:digit:] should say exactly
> > what it matches. Then it'll be clear for readers and
> > writers.
>
> Isn't it clear already?
I meant [:xdigit:], not [:digit:], in my reply. Sorry for
the typo.
bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Paul Eggert, 2019/06/11
- bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Konstantin Kharlamov, 2019/06/11
- bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Paul Eggert, 2019/06/11
- bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Mattias EngdegÄrd, 2019/06/11
- bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Drew Adams, 2019/06/11
- bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Eli Zaretskii, 2019/06/11
- bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]],
Drew Adams <=
- bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Eli Zaretskii, 2019/06/11
- bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Paul Eggert, 2019/06/11
- bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Eli Zaretskii, 2019/06/11
bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], npostavs, 2019/06/11
bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Eli Zaretskii, 2019/06/11
bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Eli Zaretskii, 2019/06/11
bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Drew Adams, 2019/06/11
bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Andy Moreton, 2019/06/11
bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]], Andy Moreton, 2019/06/12