[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34373: Acknowledgement (26.1; Missing range check in rx-submatch-n)
From: |
Lars Ingebrigtsen |
Subject: |
bug#34373: Acknowledgement (26.1; Missing range check in rx-submatch-n) |
Date: |
Sun, 23 Jun 2019 20:20:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Mattias EngdegÄrd <mattiase@acm.org> writes:
> * lisp/emacs-lisp/rx.el (rx-submatch): Type and range check (Bug#34373).
[...]
> (defun rx-submatch-n (form)
> "Parse and produce code from FORM, which is `(submatch-n N ...)'."
> (let ((n (nth 1 form)))
> + (unless (and (integerp n) (> n 0))
> + (error "rx `submatch-n' argument must be positive"))
This looks like an eminently reasonable sanity check to me, but I'm
quite unfamiliar with the rx machinery. Just push the change?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#34373: Acknowledgement (26.1; Missing range check in rx-submatch-n),
Lars Ingebrigtsen <=