[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#22114: 24.5; [PATCH] Allow profiler.el to display reports after stop
From: |
Lars Ingebrigtsen |
Subject: |
bug#22114: 24.5; [PATCH] Allow profiler.el to display reports after stopping |
Date: |
Tue, 25 Jun 2019 16:46:47 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
> I don't really understand why profiler.el insists on having the
> profiler running for providing the profile. The much simpler patch
> below makes it possible for me to invoke profiler-report whether a
> profile is running or not. Does it work for you? If not, can you
> tell what I missed?
>
> --- lisp/profiler.el~4 2015-11-11 07:57:32.000000000 +0200
> +++ lisp/profiler.el 2015-12-08 17:54:27.380084700 +0200
> @@ -216,19 +216,17 @@
>
> (defun profiler-cpu-profile ()
> "Return CPU profile."
> - (when (profiler-running-p 'cpu)
> - (profiler-make-profile
> - :type 'cpu
> - :timestamp (current-time)
> - :log (profiler-cpu-log))))
> + (profiler-make-profile
> + :type 'cpu
> + :timestamp (current-time)
> + :log (profiler-cpu-log)))
[etc]
The discussion then turned to other things (like getting in-progress
reports), but this seems like the simplest solution that solves the
originally stated problem. But it wasn't applied -- I can do that now,
if that's convenient...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#22114: 24.5; [PATCH] Allow profiler.el to display reports after stopping,
Lars Ingebrigtsen <=