bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24960: 25.1; etags incorrectly indexes quoted Erlang atoms


From: David Hull
Subject: bug#24960: 25.1; etags incorrectly indexes quoted Erlang atoms
Date: Tue, 25 Jun 2019 10:35:37 -0700

Yes, I agree that my patch should have had the braces you're suggesting. Thanks for the fix.

On Tue, Jun 25, 2019 at 10:26 AM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: david.hull@openx.com24960@debbugs.gnu.org
> Date: Tue, 25 Jun 2019 19:13:55 +0200
>
>        if (len > 0)
> -     make_tag (cp, len, true, s, cp + len - s, lineno, linecharno);
> +        /* If the name is quoted, the quotes are not part of the name. */
> +        if (len > 2 && cp[0] == '\'' && cp[len - 1] == '\'')
> +          {
> +            cp++;
> +            len -= 2;
> +          }
> +     make_tag (cp, len, true, s, pos, lineno, linecharno);
>
> I think what was meant was that the make_tag should be in that "if"
> branch, so I slapped a brace pair around the new lines.

Yes, thanks.


--
David Hull

reply via email to

[Prev in Thread] Current Thread [Next in Thread]