[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters
From: |
Kévin Le Gouguec |
Subject: |
bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters |
Date: |
Wed, 26 Jun 2019 08:16:44 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
And here is the third set of patches.
0001-Preserve-text-properties-in-y-or-n-p-prompts.patch
Description: Text Data
0002-Tweak-dired-warning-about-wildcard-characters.patch
Description: Text Data
The first patch is unchanged (it adjusts y-or-n-p so that the prompt's
text properties are preserved), the second patch uses the new
(literal …) feature from rx and adds a test case for
dired--isolated-char-p[1].
Quoting my previous email:
> Some things I wonder about:
>
> 1. About read--propertize-prompt…
>
> 1. Should the function return a copy of its argument instead of
> propertizing it directly?
>
> 2. Is it properly named? Does it fit in subr.el? I placed it there
> because I figured other users of read-char in subr.el could use
> it, e.g. read-char-choice.
>
> 2. dired-aux.el already contains some logic to detect isolated
> characters; I could not think of a way to re-use it, so I added my
> own functions to find *non*-isolated characters. I added unit tests
> for these new functions; still, there may be some redundancy there.
Thank you for your time.
[1] (should-not (dired--isolated-char-p "foo `bar`?" 9))
bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters,
Kévin Le Gouguec <=
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Drew Adams, 2019/06/26
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Stefan Monnier, 2019/06/26
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Noam Postavsky, 2019/06/27
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Kévin Le Gouguec, 2019/06/28
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Drew Adams, 2019/06/28
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Kévin Le Gouguec, 2019/06/28
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Drew Adams, 2019/06/28
- bug#35564: [PATCH v3] Tweak dired warning about "wildcard" characters, Noam Postavsky, 2019/06/29