[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for
From: |
Alex Branham |
Subject: |
bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line |
Date: |
Wed, 14 Aug 2019 10:16:52 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
On Wed 14 Aug 2019 at 10:56, Noam Postavsky <npostavs@gmail.com> wrote:
>> + (when erc-echo-timestamps
>> + (when-let ((stamp (get-text-property (point) 'timestamp))
>> + (message (format-time-string erc-echo-timestamp-format stamp)))
>> + (unless (string= message (current-message))
>> + (message "%s" message)))))
>
> I'm not an erc user, so perhaps it's just expected to be this way, but
> this sounds too aggressive to me. E.g., if you run a command like
> describe-key-briefly its message will immediately be replaced by the
> timestamp.
Most of the time we won't be echoing a timestamp since point will be in
the same line as the prompt (i.e. the area where you compose a message).
> I was thinking erc-echo-timestamp would just save the last timestamp it
> sent in a buffer-local variable, and then only send a new message if the
> current timestamp is different.
That's certainly possible to do as well. If others prefer that, I can
write that version up.
Alex
- bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line, Alex Branham, 2019/08/13
- bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line, Lars Ingebrigtsen, 2019/08/13
- bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line, Noam Postavsky, 2019/08/13
- bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line, Alex Branham, 2019/08/13
- bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line, Eli Zaretskii, 2019/08/13
- bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line, Alex Branham, 2019/08/14
- bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line, Eli Zaretskii, 2019/08/14
- bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line, Noam Postavsky, 2019/08/14
- bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line,
Alex Branham <=
bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line, Stefan Monnier, 2019/08/14