[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#36603: [PATCH] Simplify calling convention of describe_map
From: |
Stefan Kangas |
Subject: |
bug#36603: [PATCH] Simplify calling convention of describe_map |
Date: |
Tue, 20 Aug 2019 18:02:56 +0200 |
Noam Postavsky <npostavs@gmail.com> writes:
>
> Noam Postavsky <npostavs@gmail.com> writes:
>
> > Stefan Kangas <stefan@marxist.se> writes:
> >
> >> + Lisp_Object seen_orig = Qnil;
> >> + Lisp_Object *seen = &seen_orig;
> >
> > Do we really need the seen_orig variable? It looks like there is no
> > reason for having seen as a pointer at all, but maybe I'm missing
> > something.
>
> Actually, maybe the patch is wrong (i.e., over-simplifying), because it
> has describe_map start with a fresh seen pointer each time; but the
> current code passes the same pointer to each describe_map call in a
> loop.
Thanks for that feedback. I'll take another look and get back to you.
Best regards,
Stefan Kangas