[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive
From: |
Basil L. Contovounesios |
Subject: |
bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive |
Date: |
Wed, 02 Oct 2019 00:54:38 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Stefan Kangas <stefan@marxist.se> writes:
> I've attached a patch which I believe would do this in a reasonable way.
Sorry, I haven't followed the discussion, but I have a minor nit:
> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
> index ef0c5171de..5601e4d630 100644
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -1046,10 +1046,12 @@ package-buffer-info
> (let ((file-name (match-string-no-properties 1))
> (desc (match-string-no-properties 2))
> (start (line-beginning-position)))
> - ;; The terminating comment format could be extended to accept a
> - ;; generic string that is not in English.
> + ;; This warning was added in Emacs 27.1, and should be removed at
> + ;; the earliest in version 31.1. The idea is to phase out the
> + ;; requirement for a "footer line" without unduly impacting users
> + ;; on earlier Emacs versions. See Bug#26490 for more details.
> (unless (search-forward (concat ";;; " file-name ".el ends here"))
> - (error "Package lacks a terminating comment"))
> + (warn "Package lacks a terminating comment"))
Shouldn't this be (lwarn 'package ...) or similar?
(See, for example, the call to lwarn in package-initialize.)
Thanks,
--
Basil
- bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive,
Basil L. Contovounesios <=