bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24694: Document url--allow-chars for external use?


From: Hong Xu
Subject: bug#24694: Document url--allow-chars for external use?
Date: Sat, 12 Oct 2019 11:23:48 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 10/12/19 2:11 AM, Eli Zaretskii wrote:

I have a couple of minor comments:

I've attached an update.



The log message should specify each file with leading directories
starting from the root of the Emacs tree.  E.g., url-util.el should be
shown as lisp/url/url-util.el.

Done.


Also, please always mention the bug number in the log message.

Done.


+allowed characters.  Otherwise, ALLOWED-CHARS should be either a
+vector whose Nth element is non-nil if character N is allowed or
+a list of allowed chars.                                     ^

Please insert a comma where indicated, it will make the sentence
easier to read.

I swapped the two choices (the shorter one goes first) and hopefully this will 
be easier to read. Also updated the doc in url.texi.

Attachment: 0001-Make-url-hexify-string-accept-a-list-of-allowed-char.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]