[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#37755: Logic in init_fringe_bitmap should be moved to backends (mayb
From: |
Eli Zaretskii |
Subject: |
bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap) |
Date: |
Tue, 15 Oct 2019 12:33:31 +0300 |
> From: Carlos Pita <carlosjosepita@gmail.com>
> Date: Mon, 14 Oct 2019 23:30:08 -0300
>
> In fringe.c you have init_fringe_bitmap with this structure:
>
> ```
> #if defined (HAVE_X_WINDOWS)
> ...
> #ifdef USE_CAIRO
> ...
> #endif
> ...
> #endif
> #ifdef HAVE_NTGUI
> ...
> #endif
> if (!once_p)
> {
> ....
> rif->define_fringe_bitmap (...)
> ....
> }
> ```
>
> Now, this is backend specific code that should be moved behind the
> redisplay_interface.
Yes, it should.
> It seems to me that the obvious candidate to host that code is
> define_fringe_bitmap.
No, I think we need another interface, as define_fringe_bitmap is used
directly from other places.
- bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap), Carlos Pita, 2019/10/14
- bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap),
Eli Zaretskii <=
- bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap), Carlos Pita, 2019/10/15
- bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap), Carlos Pita, 2019/10/15
- bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap), Carlos Pita, 2019/10/16
- bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap), Carlos Pita, 2019/10/16
- bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap), Eli Zaretskii, 2019/10/20
- bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap), Carlos Pita, 2019/10/20
- bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap), Eli Zaretskii, 2019/10/20
- bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap), Carlos Pita, 2019/10/20
- bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap), Eli Zaretskii, 2019/10/26
- bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap), Carlos Pita, 2019/10/26