bug#42383: 28.0.50; Two bugs with M-x compile

[Alex Branham]

On Thu 16 Jul 2020 at 14:55, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>         * lisp/shell.el (shell-dynamic-complete-functions): Move
>         pcomplete-completions-at-point down the list so that filename
>         completion has a chance to complete before pcompletion.
>         
>         Fixes bug#34330
>
> yet, `pcomplete-completions-at-point` is supposed to perform filename
> completion also (via `pcomplete-default-completion-function`), so
> I think `pcomplete-completions-at-point` should come first and I suspect
> that the problem in bug#34330 is internal to pcomplete and the above
> commit just worked around it.

I find pcomplete really confusing (why is it that there's a whole second
kind of completion framework outside completion-at-point?). But yes,
sounds like this should be reverted. I didn't notice this regression
since I use ivy which obviates the need to re-complete after typing a
letter.

Someone will need to reopen bugs #10417 and #34330.

Alex