bug#44638: [PATCH 1/2] autorevert: don't reuse existing watch descriptors

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: sbaugh@catern.com,  44638@debbugs.gnu.org
> Date: Wed, 02 Dec 2020 16:17:01 +0100
> 
> Eli, could you run autorevert-test on MS Windows, for the w32notify
> backend? Either a complete run, or just
> 
> $ make -C test autorevert-tests 
> SELECTOR=auto-revert-test07-auto-revert-several-buffers

auto-revert-test07-auto-revert-several-buffers succeeds.  Running the
entire test finds 2 failures:

  2 unexpected results:
     FAILED  auto-revert-test04-auto-revert-mode-dired
     FAILED  auto-revert-test05-global-notify

The evidence for the first failure is:

  Test auto-revert-test04-auto-revert-mode-dired condition:
      (ert-test-failed
       ((should-not
         (string-match name
                       (substring-no-properties ...)))
        :form
        (string-match "auto-revert-testhf8BmX" "  c:/Documents and 
Settings/Zaretskii/Local Settings/Temp:\12  total used in directory 1178 
available 46.5 GiB\12  drwxrwxrwx  1 Zaretskii None      0 2012-04-16  ..\12  
drwxrwxrwx  1 Zaretskii None      0 12-02 17:35 .\12  drwxrwxrwx  1 Zaretskii 
None      0 09-25 21:47 
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\12  drwxrwxrwx  1 
Zaretskii None      0 12-01 17:26 acrord32_sbx\12  -rw-rw-rw-  1 Zaretskii None 
 38296 12...(the rest elided)

Not sure what that means.

The second test fails because:

  Test auto-revert-test05-global-notify condition:
      (ert-test-failed
       ((should
         (buffer-local-value 'auto-revert-notify-watch-descriptor buf-1))
        :form
        (buffer-local-value auto-revert-notify-watch-descriptor #<killed 
buffer>)
        :value nil))

Let me know if I can help you more.