[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#45355: 26.1; shr-tag-base doesn't handle <base href=""> properly
|
From: |
Lars Ingebrigtsen |
|
Subject: |
bug#45355: 26.1; shr-tag-base doesn't handle <base href=""> properly |
|
Date: |
Tue, 22 Dec 2020 07:47:54 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Łukasz Stelmach <steelman@post.pl> writes:
> For what it's worth, W3C HTML Validator claims that a document with an
> empty string in the href attribute of a base tag
>
> <base href="">
>
> is valid. I found such document recently in my INBOX and Gnus was unable
> to display it correctly because the second string-match in
> shr-parse-base breaks when local is nil. My solution is not to call
> shr-parse-base not only when href is not present but also when href is
> an empty string.
>
> The patch has been crated on the current master branch.
Looks good to me; I've now applied it to Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no