bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#45539: 26.3; `add-to-ordered-list': Add optional arg for :test predi


From: Lars Ingebrigtsen
Subject: bug#45539: 26.3; `add-to-ordered-list': Add optional arg for :test predicate for hash table
Date: Wed, 30 Dec 2020 04:48:19 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Drew Adams <drew.adams@oracle.com> writes:

> Please consider adding an optional arg TEST-PREDICATE, which will be
> passed to the hash table (and which will default to `eq').

Since the ordering is hard-coded to `<', allowing the things being
compared are presumably all numbers, so allowing specifying the
comparison function doesn't make much sense.

However, using `eq' for numbers doesn't make much sense, either -- `eql'
would be better.  Looking at the in-tree usages, switching to `eql'
shouldn't make much difference, so I've done the daring thing and
switched to `eql'.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





reply via email to

[Prev in Thread] Current Thread [Next in Thread]