[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompat
From: |
Protesilaos Stavrou |
Subject: |
bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) |
Date: |
Mon, 01 Mar 2021 16:52:20 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
On 2021-03-01, 16:38 +0200, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Mauro Aranda <maurooaranda@gmail.com>
>> Cc: Eli Zaretskii <eliz@gnu.org>, 45068@debbugs.gnu.org
>> Date: Sun, 28 Feb 2021 10:33:14 -0300
>>
>> The rest looks good to me, but let's wait for the other people involved
>> to give their feedback.
>
> It LGTM as well, thanks.
Thank you! Just to add that Basil (now in cc) shared some more
insights. The current version is this (any mistakes are mine):
(defun require-theme (theme &optional path)
"Load THEME stored in `custom-theme-load-path'.
THEME is a symbol that corresponds to the file name without its file
type extension. That is assumed to be either '.el' or '.elc'.
When THEME is an element of `custom-available-themes', load it and ask
for confirmation if it is not considered safe by `custom-safe-themes'.
Otherwise load the file indicated by THEME, if present. In the latter
case, the file is intended to work as the basis of a theme declared
with `deftheme'.
If optional PATH is non-nil, it should be a list of directories
to search for THEME in, instead of `custom-theme-load-path'.
PATH should have the same form as `load-path' or `exec-path'."
(cond
((memq theme (custom-available-themes))
(load-theme theme))
((let* ((dirs (or path (custom-theme--load-path)))
(file (unless (featurep theme)
(locate-file (symbol-name theme) dirs '(".el" ".elc")))))
(when file
(load-file file))))))
--
Protesilaos Stavrou
protesilaos.com
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Eli Zaretskii, 2021/03/01
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible),
Protesilaos Stavrou <=
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Mauro Aranda, 2021/03/01
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Mauro Aranda, 2021/03/01
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Basil L. Contovounesios, 2021/03/01
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Protesilaos Stavrou, 2021/03/02
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Eli Zaretskii, 2021/03/02
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Basil L. Contovounesios, 2021/03/02
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Basil L. Contovounesios, 2021/03/02