[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompat
From: |
Mauro Aranda |
Subject: |
bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) |
Date: |
Thu, 04 Mar 2021 13:53:04 -0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Protesilaos,
Protesilaos Stavrou <info@protesilaos.com> writes:
> Hello again!
>
> As noted earlier, please find attached the patch that upgrades the
> themes to their newest version 1.2.0. I tested it with Basil's latest
> patch for 'require-theme', though it still works with the variant of
> that function currently in trunk.
[...]
> ;;;###autoload
> (when (and (boundp 'custom-theme-load-path) load-file-name)
> (add-to-list 'custom-theme-load-path
> (file-name-as-directory (file-name-directory load-file-name))))
A nit: I think this code should avoid adding the value of
custom-theme-directory or the built-in theme directory name to
custom-theme-load-path , if `custom-theme-directory' (for the former) or
t (for the latter) are already present in custom-theme-load-path. In
particular, a theme distributed with Emacs should at least check for t,
to avoid a repeated entry.
I've noticed that the leuven theme has a similar code as well: I think
that is a (really minor) bug.
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), (continued)
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Basil L. Contovounesios, 2021/03/03
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Protesilaos Stavrou, 2021/03/03
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Basil L. Contovounesios, 2021/03/03
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Protesilaos Stavrou, 2021/03/03
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Mauro Aranda, 2021/03/04
- bug#45068: [PATCH] Modus themes 1.2.0 (was: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible)), Protesilaos Stavrou, 2021/03/04
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible),
Mauro Aranda <=
- bug#45068: [PATCH] Modus themes 1.2.0, Basil L. Contovounesios, 2021/03/04
- bug#45068: [PATCH] Modus themes 1.2.0, Protesilaos Stavrou, 2021/03/04
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Mauro Aranda, 2021/03/04
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Protesilaos Stavrou, 2021/03/05
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Basil L. Contovounesios, 2021/03/05
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Protesilaos Stavrou, 2021/03/05
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Mauro Aranda, 2021/03/04
- bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible), Protesilaos Stavrou, 2021/03/05
- bug#45068: [PATCH] Modus themes 1.2.0, Basil L. Contovounesios, 2021/03/05
- bug#45068: [PATCH] Modus themes 1.2.0, Protesilaos Stavrou, 2021/03/05