bug#47205: 27.1.91; [bug] unexpected input event interrupted expand-file

[LinSun]

Hi Eli,

 

The patch work like a charm.
Look forward you merge it.

Thanks.

 

From: Michael Albinus
Sent: Thursday, March 18, 2021 18:07
To: Eli Zaretskii
Cc: LinSun; 47205@debbugs.gnu.org
Subject: Re: bug#47205: 27.1.91; [bug] unexpected input event interrupted expand-file

 

Eli Zaretskii <eliz@gnu.org> writes:

 

>> It’s from the issue https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_bbatsov_helm-2Dprojectile_issues_154&d=DwIFaQ&c=8lBT5Jra4Bm5rFhLVR7k1wx3__gIUgr523Abjhgq6Gg&r=6xk5MptCw9C5cby5Hg_N-g&m=HR8oZPO5qkb1Y4lPUBjXJ4J4L5Q5MzNutLnwdB02m28&s=yYz4_sQZPvbSxDPgIV-z6qAq9KTPeD77CqzW6R7YDzM&e= ,

>>

>> “[bug] `helm-projectile-find-file' empty candidate when there is "*.iso/" folder”

>>

>> Through the traceback I attached in first mail, the dbus event cause a unexpected return value in line

>>

>> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_emacs-2Dhelm_helm_blob_26d4e9e4d38a143d7dfb2fe206eacbc326944532_helm.el-23L4649&d=DwIFaQ&c=8lBT5Jra4Bm5rFhLVR7k1wx3__gIUgr523Abjhgq6Gg&r=6xk5MptCw9C5cby5Hg_N-g&m=HR8oZPO5qkb1Y4lPUBjXJ4J4L5Q5MzNutLnwdB02m28&s=yyd-WrGYdRC7wcnyQAkKp5hmY9VGXpu_E_uMLUKqQSU&e= ,

>>

>> Then it’s function will show nothing.

> 

> Is this because helm uses while-no-input or throw-on-input?  If so,

> does it help to bind while-no-input-ignore-events to a list that

> includes this kind of dbus events?

 

This doesn't help (yet), because dbus-event isn't handled via

while-no-input-ignore-events. The appended patch extends this for

dbus-event and file-notify. The following adapted test works then:

 

--8<---------------cut here---------------start------------->8---

# emacs --batch --eval "(message \"%s\" (catch 'input (let ((while-no-input-ignore-events (cons 'dbus-event while-no-input-ignore-events)) (throw-on-input 'input)) (expand-file-name \"a.iso/b\" \"/\"))))"

--8<---------------cut here---------------end--------------->8---

 

Is it OK to push this to the master branch (plus doc adaptions)?

 

Best regards, Michael.