bug#50340: Fix remote-location in vc-git-log-incoming

[Dmitry Gutov]

On 05.09.2021 19:36, Juri Linkov wrote:

> > Ah, I see what you are referring to.
> >
> > But does the feature work then?
> >
> > With your patch, I can pass some alternative upstream to the command, and
> > it fails at the end with something like:
> >
> > fatal: ambiguous argument 'HEAD..upstream': unknown revision or path not in
> > the working tree.
> > Use '--' to separate paths from revisions, like this:
> > 'git <command> [<revision>...] -- [<file>...]'
>
> But this means that my fix worked, because in vc-git-log-incoming
> I fixed the first command `git fetch`, but it fails in your case
> in the second command `git log HEAD..upstream`.

If it works for you, go ahead. I just couldn't make the command work 
(patched or not) with either of the projects I tried it on.

> > > > So if you have a stable repro (some alternative completing-read-function?),
> > > > you can go ahead and install.
> > > Regarding the default completing-read-function, the prompt of 'C-u C-x v I'
> > > doesn't provide completion on remote names.  Maybe this should be improved
> > > as well.
> >
> > I guess some new backend action ('remote-locations'?) could help with that.
>
> Would be nice.  Maybe just 'vc-read-revision' can be used,
> but by removing branch names after the slash in "upstream/branch",
> then uniquify remaining upstream names.

I'm not sure. This should work for every backend where log-outgoing and 
log-incoming work, right?

Do remotes feature in branch names the same way in Git, Hg and Bzr?