bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#50767: 28.0.50; Warnings about snprintf in image.c on armv7l


From: Alan Third
Subject: bug#50767: 28.0.50; Warnings about snprintf in image.c on armv7l
Date: Mon, 4 Oct 2021 22:45:06 +0100

On Thu, Sep 23, 2021 at 11:49:37PM +0100, Alan Third wrote:
> On Thu, Sep 23, 2021 at 11:38:06PM +0100, Basil L. Contovounesios wrote:
> > ...which would mean this only holds in the common case that
> > face_font_size has fewer than 5 digits, right?
> 
> Looks that way.
> 
> I suppose in this particular case we could limit the font size to a
> maximum of 9999 or something, but surely there's a better way of
> calculating string sizes?

I've implemented a pretty basic check so we shouldn't accidentally
overrun the buffer. See attached.

-- 
Alan Third

Attachment: 0001-Fix-potential-buffer-overflow-bug-50767.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]