[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#1501: Emacs 22 loses undo buffer
From: |
Eli Zaretskii |
Subject: |
bug#1501: Emacs 22 loses undo buffer |
Date: |
Wed, 20 Oct 2021 15:05:34 +0300 |
> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 19 Oct 2021 18:01:43 -0700
> Cc: Emerick Rogul <emerick@gmail.com>, 1501@debbugs.gnu.org,
> Chong Yidong <cyd@stupidchicken.com>
>
> + /* Remove the `face' property to save space. (Bug1501) */
> + if (!NILP (string))
> + Fremove_list_of_text_properties (make_fixnum (0),
> + make_fixnum (SCHARS (string)),
> + CALLN (Flist, Qface),
> + string);
This modifies the text properties of STRING, which you don't own.
Also, it will do unnecessary non-trivial processing when undo is
turned off.
I definitely think that with the enlarged undo-limit we should leave
this obscure situation alone. It isn't worth making such significant
low-level changes due to such obscure problems, which are arguably
cockpit errors.