[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connecti
From: |
Michael Albinus |
Subject: |
bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware? |
Date: |
Thu, 28 Oct 2021 10:02:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Jim Porter <jporterbugs@gmail.com> writes:
Hi Jim,
> Thanks. I've expanded the section about `comint-terminfo-terminal' in
> the manual to include information about how `system-uses-terminfo'
> works as well as mentioning that these variables can be declared as
> connection-local.
LGTM. Just one nit:
> color is supported. Therefore, Emacs provides an option
> -@code{comint-terminfo-terminal}, which you can set to a terminal that
> -is present in your system's terminfo database, in order to take
> -advantage of advanced features of that terminal.
> +@code{comint-terminfo-terminal} to let you choose a terminal with more
> +advanced features, as defined in your system's terminfo database.
> +When @code{system-uses-terminfo} is non-nil, Emacs will use this
> +option as the value for @env{TERM}.
"this option" sounds like Emacs uses system-uses-terminfo for TERM, at
least in my ears. Could you pls rephrase it a little bit?
Otherwise, it is OK. If nobody else objects, I would push it in your
name to the master branch, when you have reworded it.
> Thanks for taking a look.
>
> - Jim
Best regards, Michael.
- bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware?, Jim Porter, 2021/10/26
- bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware?, Michael Albinus, 2021/10/27
- bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware?, Jim Porter, 2021/10/27
- bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware?,
Michael Albinus <=
- bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware?, Jim Porter, 2021/10/28
- bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware?, Michael Albinus, 2021/10/28
- bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware?, Jim Porter, 2021/10/29
- bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware?, Michael Albinus, 2021/10/29
- bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware?, Jim Porter, 2021/10/29
- bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware?, Michael Albinus, 2021/10/30