bug#54624: 29.0.50; textsec and ipv6 addresses

[Lars Ingebrigtsen]

Mattias Engdegård <mattiase@acm.org> writes:

> Here is a new attempt, simplified a bit:
>
>   (rx-let ((octet (** 1 3 (in "0-9")))
>            (ipv4 (: octet (= 3 "."  octet)))
>            (hextet (** 1 4 (in "0-9a-f")))
>            (ipv6 (: (? "::") hextet (* (or ":" "::") hextet)
>                     (? ":" (or ":" ipv4)))))
>     (string-match-p (rx bos (or ipv4 ipv6 (: "[" ipv6 "]")) eos)
>                     domain)))

I don't really read rx syntax well, but that seems reasonable to me on
first sight.

> We could simplify it further and relax the requirement on octets and
> hextets (which seems to be what they are called, rather incongruously)
> but then it wouldn't catch what you previously thought were
> suspicious.

You misunderstand -- the function wasn't introduced to say something
about (certain) raw addresses being suspicious.  It was introduced to
say that they aren't.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no