bug#54970: 28.1; Some emoji no longer display

[Alan Third]

On Sun, Apr 17, 2022 at 08:47:07PM +0100, Alan Third wrote:
> On Sun, Apr 17, 2022 at 08:27:45PM +0100, Alan Third wrote:
> > On Sun, Apr 17, 2022 at 09:58:56PM +0300, Eli Zaretskii wrote:
> > > No idea.  Maybe it's a macOS thing or something?
> > 
> > I'm pretty sure that I've never ever seen NS Emacs on macOS produce
> > anything but a blank square (and it's always a square) for missing
> > characters.
> 
> Hmm, in fact, is this, from nsterm.m, the culprit?
> 
>     case GLYPHLESS_GLYPH:
>       if (s->for_overlaps || (s->cmp_from > 0
>                             && ! s->first_glyph->u.cmp.automatic))
>         s->background_filled_p = 1;
>       else
>         ns_maybe_dumpglyphs_background
>           (s, s->first_glyph->type == COMPOSITE_GLYPH);
>       /* ... */
>       /* Not yet implemented.  */
>       /* ... */
>       break;

To answer my own question: yes. Yes it is.

Patch attached.

It doesn't look to me like it displays quite right, the right hand
side of the hex code gets cut off on my Mac and under GNUstep only the
first line is displayed, but I can't see any reason for it.

Maybe this is better than nothing, though.

-- 
Alan Third

0001-Fix-glyphless-glyph-display-on-NS-bug-54970.patch
Description: Text Data