[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame
From: |
Alan Mackenzie |
Subject: |
bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame |
Date: |
Wed, 6 Jul 2022 19:05:44 +0000 |
Hello, Andreas.
On Wed, Jul 06, 2022 at 20:58:22 +0200, Andreas Schwab wrote:
> On Jul 06 2022, Alan Mackenzie wrote:
> > diff --git a/src/minibuf.c b/src/minibuf.c
> > index 0fc7f2caa1..7723167d4d 100644
> > --- a/src/minibuf.c
> > +++ b/src/minibuf.c
> > @@ -896,6 +896,10 @@ read_minibuf (Lisp_Object map, Lisp_Object initial,
> > Lisp_Object prompt,
> > /* Don't allow the user to undo past this point. */
> > bset_undo_list (current_buffer, Qnil);
> > + /* Ensure that the minibuffer frame has the window-system focus.
> > + This is sometimes needed for minibuffer-only frames. */
> > + Fx_focus_frame (mini_frame, Qt);
> Can't this steal focus from unrelated windows?
Not obviously. We're about to run the recursive edit for read_minibuf,
so the frame with the mini-window should have the focus anyway.
The only possibility of theft that I see is if a normal frame already
has its focus redirected to a minibuffer frame. In that case the normal
frame will lose focus.
I don't think this will happen, or if it does, it won't be serious.
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
> "And now for something completely different."
--
Alan Mackenzie (Nuremberg, Germany).
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, (continued)
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Alan Mackenzie, 2022/07/04
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Eli Zaretskii, 2022/07/04
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Alan Mackenzie, 2022/07/05
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Eli Zaretskii, 2022/07/05
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Alan Mackenzie, 2022/07/05
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Alan Mackenzie, 2022/07/06
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Eli Zaretskii, 2022/07/06
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Alan Mackenzie, 2022/07/06
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Stefan Monnier, 2022/07/06
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Andreas Schwab, 2022/07/06
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame,
Alan Mackenzie <=
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Andreas Schwab, 2022/07/06
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Alan Mackenzie, 2022/07/06
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Alan Mackenzie, 2022/07/07
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Stefan Monnier, 2022/07/07
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Alan Mackenzie, 2022/07/08
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Stefan Monnier, 2022/07/08
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, martin rudalics, 2022/07/07
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Alan Mackenzie, 2022/07/07
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, martin rudalics, 2022/07/08
- bug#56305: 29.0.50; 'yes-or-no-p' deselects minibuffer frame, Alan Mackenzie, 2022/07/08