[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56487: xgselect race condition leading to abort when USE_GTK not def
From: |
Po Lu |
Subject: |
bug#56487: xgselect race condition leading to abort when USE_GTK not defined |
Date: |
Mon, 11 Jul 2022 11:13:04 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Tom Gillespie <tgbugs@gmail.com> writes:
> -#ifdef USE_GTK
> bool already_has_events;
> -#endif
>
> if (xg_select_suppress_count)
> return pselect (fds_lim, rfds, wfds, efds, timeout, sigmask);
> @@ -126,8 +132,8 @@ xg_select (int fds_lim, fd_set *rfds, fd_set *wfds,
> fd_set *efds,
> context = g_main_context_default ();
> acquire_select_lock (context);
>
> -#ifdef USE_GTK
> already_has_events = g_main_context_pending (context);
> +#ifdef USE_GTK
> #ifndef HAVE_PGTK
> already_has_events = already_has_events && x_gtk_use_native_input;
> #endif
> @@ -179,12 +185,6 @@ xg_select (int fds_lim, fd_set *rfds, fd_set *wfds,
> fd_set *efds,
> tmop = &tmo;
> }
>
> -#ifndef USE_GTK
> - fds_lim = max_fds + 1;
> - nfds = thread_select (pselect, fds_lim,
> - &all_rfds, have_wfds ? &all_wfds : NULL, efds,
> - tmop, sigmask);
> -#else
> /* On PGTK, when you type a key, the key press event are received,
> and one more key press event seems to be received internally.
>
> @@ -217,7 +217,6 @@ xg_select (int fds_lim, fd_set *rfds, fd_set *wfds,
> fd_set *efds,
> FD_ZERO (efds);
> our_fds++;
> }
> -#endif
>
> if (nfds < 0)
> retval = nfds;
> @@ -248,11 +247,7 @@ xg_select (int fds_lim, fd_set *rfds, fd_set *wfds,
> fd_set *efds,
>
> /* If Gtk+ is in use eventually gtk_main_iteration will be called,
> unless retval is zero. */
> -#ifdef USE_GTK
> need_to_dispatch = retval == 0;
> -#else
> - need_to_dispatch = true;
> -#endif
>
> /* xwidgets make heavy use of GLib subprocesses, which add their own
> SIGCHLD handler at arbitrary locations. That doesn't play well
Thanks. Why did the code previously under !USE_GTK have to be removed?
- bug#56487: xgselect race condition leading to abort when USE_GTK not defined, Tom Gillespie, 2022/07/10
- bug#56487: xgselect race condition leading to abort when USE_GTK not defined, Po Lu, 2022/07/10
- bug#56487: xgselect race condition leading to abort when USE_GTK not defined, Tom Gillespie, 2022/07/10
- bug#56487: xgselect race condition leading to abort when USE_GTK not defined,
Po Lu <=
- bug#56487: xgselect race condition leading to abort when USE_GTK not defined, Tom Gillespie, 2022/07/10
- bug#56487: xgselect race condition leading to abort when USE_GTK not defined, Po Lu, 2022/07/11
- bug#56487: xgselect race condition leading to abort when USE_GTK not defined, Tom Gillespie, 2022/07/11
- bug#56487: xgselect race condition leading to abort when USE_GTK not defined, Po Lu, 2022/07/11
- bug#56487: xgselect race condition leading to abort when USE_GTK not defined, Tom Gillespie, 2022/07/11
- bug#56487: xgselect race condition leading to abort when USE_GTK not defined, Eli Zaretskii, 2022/07/12
- bug#56487: xgselect race condition leading to abort when USE_GTK not defined, Tom Gillespie, 2022/07/15