[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief
From: |
Alan Third |
Subject: |
bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief |
Date: |
Mon, 11 Jul 2022 09:01:07 +0100 |
On Mon, Jul 11, 2022 at 09:50:11AM +0800, Po Lu via Bug reports for GNU Emacs,
the Swiss army knife of text editors wrote:
> Daniel Martín <mardani29@yahoo.es> writes:
>
> > Daniel Martín via "Bug reports for GNU Emacs, the Swiss army knife of
> > text editors" <bug-gnu-emacs@gnu.org> writes:
> >
> >>>
> >>> Thanks. But I think the use of static variables there is rather ugly,
> >>> and it would be much nicer if we replicated the `x_setup_relief_color'
> >>> logic there.
> >>>
> >>> Do you want to work on that, or should I?
> >>
> >> Thanks, I can give it a try.
> >
> > Here's a patch where the static variables are now proper fields in the
> > ns_output structure. Is that what you had in mind?
>
> Yes, this would be great. Thanks.
>
> Alan might have some comments; if he doesn't, I'll install this now.
No, looks fine to me.
--
Alan Third