[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend
From: |
Po Lu |
Subject: |
bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend |
Date: |
Fri, 15 Jul 2022 20:58:46 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Manuel Giraud <manuel@ledu-giraud.fr> writes:
> Here is a new version of this patch. What's new:
>
> - fix some comments
>
> - format arguments list on both new functions and the one I have
> modified their arguments
>
> - add some forgot freeing in `release_shadow_gcs'
Thanks. One (late) last comment on the documentation:
> +@item highlightForeground
> +Foreground color for a highlighted menu item.
> +@item highlightBackground
> +Background color for a highlighted menu item.
Shouldn't this say "the menu item highlighted by the mouse"? Otherwise,
what "highlighted" means is not exactly clear.
> +** New X resources: "highlightForeground" and "highlightBackground"
> +Only in the Lucid build, this controls colors used for highlighted
> +menu item widget.
And here, shouldn't "widget" be in plural?
- bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend, Manuel Giraud, 2022/07/13
- bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend, Po Lu, 2022/07/13
- bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend, Manuel Giraud, 2022/07/14
- bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend, Po Lu, 2022/07/14
- bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend, Manuel Giraud, 2022/07/14
- bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend, Po Lu, 2022/07/14
- bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend, Manuel Giraud, 2022/07/15
- bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend, Manuel Giraud, 2022/07/15
- bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend,
Po Lu <=
- bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend, Manuel Giraud, 2022/07/15
- bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend, Po Lu, 2022/07/15
- bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend, Manuel Giraud, 2022/07/16
- bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend, Po Lu, 2022/07/16