[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled
From: |
Juri Linkov |
Subject: |
bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled |
Date: |
Sun, 24 Jul 2022 19:52:19 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
>> All affected mouse commands mouse-yank-from-menu, mouse-yank-at-click,
>> mouse-yank-primary, mouse-yank-secondary have the same line:
>>
>> (or mouse-yank-at-point (mouse-set-point event))
>>
>> So when the region is deleted by delete-selection-pre-hook
>> `mouse-set-point' tries to set point using outdated information
>> of the event's position in the deleted region.
>>
>> Maybe delete-selection-pre-hook could directly modify the event?
>> Everything works fine with this:
>>
>> ((eq type 'yank-on-region)
>> (let ((pos (posn-point (event-end last-nonmenu-event))))
>> (when (and (>= pos (region-beginning))
>> (<= pos (region-end)))
>> (delete-selection-helper 'yank)
>> (setf (nth 5 (nth 1 last-nonmenu-event))
>> (region-beginning)))))
>>
>> But is this a good idea?
>
> It sounds kinda gross. Would it be possible to rewrite these commands
> to that point is set before the deletion is done, or is that unfeasible?
delete-selection-mode deletes the region in pre-command-hook
before running the command.
Maybe then these commands could have special handling of delete-selection-mode?
They already contain special handling of select-active-regions:
;; Without this, confusing things happen upon e.g. inserting into
;; the middle of an active region.
(when select-active-regions
(let (select-active-regions)
(deactivate-mark)))
- bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, (continued)
- bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, Visuwesh, 2022/07/13
- bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, Juri Linkov, 2022/07/13
- bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, Juri Linkov, 2022/07/13
- bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, Lars Ingebrigtsen, 2022/07/14
- bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, Juri Linkov, 2022/07/14
- bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, Lars Ingebrigtsen, 2022/07/14
- bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, Juri Linkov, 2022/07/15
- bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, Lars Ingebrigtsen, 2022/07/16
- bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, Juri Linkov, 2022/07/17
- bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, Lars Ingebrigtsen, 2022/07/22
- bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled,
Juri Linkov <=
- bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, Lars Ingebrigtsen, 2022/07/26
bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, David Ponce, 2022/07/13
bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, Po Lu, 2022/07/13
bug#56530: 29.0.50; mouse-2 cut selected text when cua-mode is enabled, Stefan Kangas, 2022/07/13