[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56772: 29.0.50; regexp-builder window is very tall when temp-buffer-
From: |
Juri Linkov |
Subject: |
bug#56772: 29.0.50; regexp-builder window is very tall when temp-buffer-resize-mode is enabled |
Date: |
Wed, 27 Jul 2022 10:35:23 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
> Expected result:
>
> The regexp-builder window takes 4 lines, just as when
> temp-buffer-resize-mode is not enabled.
>
> Workaround:
>
> Calling M-x fit-window-to-buffer after M-x regexp-builder resizes the
> window successfully.
Before 57354bc6 it was hard-coded to 4, so a possible fix would be
(window-height . ,(+ (if header-line-format 1 0)
(if tab-line-format 1 0)
4))
But a better fix is this:
diff --git a/lisp/emacs-lisp/re-builder.el b/lisp/emacs-lisp/re-builder.el
index 46b429ce6f..84018f06ac 100644
--- a/lisp/emacs-lisp/re-builder.el
+++ b/lisp/emacs-lisp/re-builder.el
@@ -369,7 +369,8 @@ re-builder
(get-buffer-create reb-buffer)
`((display-buffer-in-direction)
(direction . ,dir)
- (dedicated . t))))))
+ (dedicated . t)
+ (window-height . fit-window-to-buffer))))))
(font-lock-mode 1)
(reb-initialize-buffer)))
I don't know why it resizes to less lines with tab-line-mode,
but this is a separate problem.