bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#57949: git head; unportable test(1) operator


From: Thomas Klausner
Subject: bug#57949: git head; unportable test(1) operator
Date: Tue, 20 Sep 2022 09:08:52 +0200

Hi!

In
https://github.com/emacs-mirror/emacs/commit/7c8a131984ab47349381975dead1712ae25ae2c6
Makefile.in started using "==" as test(1) comparison operator.

This is not portable, only bash supports it. POSIX mandates "=".

Please apply the following patch:

--- Makefile.in.orig    2022-09-19 23:17:34.000000000 +0000
+++ Makefile.in
@@ -417,7 +417,7 @@ sanity-check:
        @v=$$(src/emacs${EXEEXT} --batch --eval \
          '(progn (defun f (n) (if (= 0 n) 1 (* n (f (- n 1))))) (princ (f 
10)))' \
          2> /dev/null); \
-       [ "X$$v" == "X3628800" ] && exit 0; \
+       [ "X$$v" = "X3628800" ] && exit 0; \
        echo; \
        echo "  \"make ${make-target}\" succeeded, but Emacs is not 
functional."; \
        cat Makefile | \

Thanks,
 Thomas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]