bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face

[Stefan Kangas]

Protesilaos Stavrou <info@protesilaos.com> writes:

> From ea287b3d918c6a2cf6181c5671187143b3774bd5 Mon Sep 17 00:00:00 2001
> Message-Id: 
> <ea287b3d918c6a2cf6181c5671187143b3774bd5.1664196100.git.info@protesilaos.com>
> From: Protesilaos Stavrou <info@protesilaos.com>
> Date: Mon, 26 Sep 2022 15:41:18 +0300
> Subject: [PATCH] Add log-edit-summary-separator face
>
> * etc/NEWS: Report on it.

This line is optional, but I'd put it below the main change and say
something like "Announce the new face."

> * lisp/vc/log-edit.el (log-edit-summary-separator): Add new face.
> (log-edit-font-lock-keywords): Replace hardcoded face attributes with
> named face.
> ---
>  etc/NEWS            | 5 +++++
>  lisp/vc/log-edit.el | 6 +++++-
>  2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/etc/NEWS b/etc/NEWS
> index 0a5b7bc29c..ced4ece35d 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -1766,6 +1766,11 @@ Writing shorter summary lines avoids truncation in 
> contexts in which
>  Git commands display summary lines.  See the two new user options
>  'vc-git-log-edit-summary-target-len' and 'vc-git-log-edit-summary-max-len'.
>
> +---
> +*** New 'log-edit-summary-separator' face
> +Styles the line that separates the log-edit headers from the log-edit
> +summary.

I'd say:

    "It is used for the 'log-edit' headers ..."

> +
>  ** Message
>
>  ---
> diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el
> index 5290616302..25b47a75af 100644
> --- a/lisp/vc/log-edit.el
> +++ b/lisp/vc/log-edit.el
> @@ -325,6 +325,10 @@ ;;; Actual code
>  (defface log-edit-summary '((t :inherit font-lock-function-name-face))
>    "Face for the summary in `log-edit-mode' buffers.")
>
> +(defface log-edit-summary-separator '((t :height 0.1 :inverse-video t 
> :extend t))

Maybe put the value on a separate line (in case we want to extend it
later)?

> +  "Face for the summary separator line in `log-edit-mode' buffers."
> +  :version "29.1")
> +
>  (defface log-edit-header '((t :inherit font-lock-keyword-face))
>    "Face for the headers in `log-edit-mode' buffers.")
>
> @@ -393,7 +397,7 @@ (defvar log-edit-font-lock-keywords
>           nil lax))
>       ("^\n"
>        (progn (goto-char (match-end 0)) (1+ (match-end 0))) nil
> -      (0 '(face (:height 0.1 :inverse-video t :extend t)
> +      (0 '(face log-edit-summary-separator
>             display-line-numbers-disable t rear-nonsticky t))))
>      (log-edit--match-first-line (0 'log-edit-summary))))

Other than those nits, LGTM (but I didn't test it).