bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#58150: 29.0.50; parse_tool_bar_item should not usually upcase "and"


From: Lars Ingebrigtsen
Subject: bug#58150: 29.0.50; parse_tool_bar_item should not usually upcase "and"
Date: Fri, 30 Sep 2022 14:34:07 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

Eli Zaretskii <eliz@gnu.org> writes:

> Isn't the capitalizing for the likes of tool-bar-add-item-from-menu,
> where the symbols are commands that aren't capitalized?

In that case, the code is wrong, because it capitalises also in the
normal case (i.e., when not using tool-bar-add-item-from-menu).

Perhaps that's the case, and people got used to it fixing all the names,
and nobody noticed that stuff like

    (define-key map [isearch-occur]
      (list 'menu-item "Show hits" 'isearch-occur
            :help "Show each search hit"
            :image '(isearch-tool-bar-image "index")))

was wrong, because "Show hits" was never displayed "unfixed".





reply via email to

[Prev in Thread] Current Thread [Next in Thread]