[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_T
From: |
Yuan Fu |
Subject: |
bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE |
Date: |
Sat, 29 Apr 2023 15:55:26 -0700 |
> On Apr 27, 2023, at 10:41 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Thu, 27 Apr 2023 12:56:07 -0700
>> Cc: dmitry@gutov.dev,
>> 62951@debbugs.gnu.org
>>
>>> c-ts-mode: Cannot load language definition: not-found,
>>> ("libtree-sitter-emacs-c" "libtree-sitter-emacs-c.dll"), "No such file or
>>> directory"
>>>
>>> It looks like your "fake emacs-c language" trick somehow misfires?
>>> The value of treesit-load-name-override-list is nil, which is not what
>>> you intended, AFAICT? The only way I can make this work is by
>>> manually customizing treesit-load-name-override-list before loading
>>> c-ts-mode.
>>
>> Duh, sorry, dumb mistake. Fixed.
>
> Thanks.
>
>>> Otherwise, looks quite good; here are some other problems I found:
>>>
>>> . some uses of FOR_EACH_TAIL are not fontified at all; examples:
>>> comp.c, line 2079, fns.c, line 189
>>
>> You mean the FOE_EACH_TAIL part isn’t fontified, or the body isn’t
>> fontified? Because the body are always fontified here. FOR_EACH_TAIL itself
>> shouldn’t be fontified since it’s just a macro call and a variable.
>
> I mean the macro itself, FOR_EACH_TAIL. If it isn't supposed to be
> fontified, then why is it fontified at line 856 of comp.c? It's
> inconsistent. (However, this is a very minor problem, so if fixing
> it is difficult, we can leave this alone for now.)
Ah, I see. FOR_EACH_TAIL’s that has a bracketed body are not skipped and still
have fontification on them. I pushed a change so that no one has fontification
now. Also thanks for the doc fix :-)
Yuan
- bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE, (continued)
- bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE, Eli Zaretskii, 2023/04/22
- bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE, Dmitry Gutov, 2023/04/23
- bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE, Yuan Fu, 2023/04/26
- bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE, Yuan Fu, 2023/04/26
- bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE, Eli Zaretskii, 2023/04/27
- bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE, Yuan Fu, 2023/04/27
- bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE, Eli Zaretskii, 2023/04/28
- bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE,
Yuan Fu <=
- bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE, Eli Zaretskii, 2023/04/30
- bug#62951: 29.0.90; c-ts-mode: Incorrect fontification due to FOR_EACH_TAIL_SAFE, Dmitry Gutov, 2023/04/27