bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#63757: 29.0.91 order of package paths changed: random old versions o


From: Eli Zaretskii
Subject: bug#63757: 29.0.91 order of package paths changed: random old versions of packages in load-path
Date: Sun, 04 Jun 2023 21:32:05 +0300

> From: Philip Kaludercic <philipk@posteo.net>
> Cc: Eli Zaretskii <eliz@gnu.org>,  artscan@list.ru,  63757@debbugs.gnu.org
> Date: Sun, 04 Jun 2023 17:37:16 +0000
> 
> > So my patch *may* be a regression for users of `package-vc`, but since
> > it's a new feature in Emacs-29, I think it's perfectly acceptable.
> > Especially because the sort it implemented is wrong (because the sort
> > predicate fails to define a partial order, so the output will depend on
> > arbitrary details of how `sort` happens to pass elements to the
> > predicate), so it's not at all clear that it does what it intends to
> > do anyway.
> > Furthermore I believe that it is mostly redundant: VC packages should
> > almost always already be sorted first by virtue of the version being
> > almost always higher than non-VC packages.
> 
> I'll do some more testing to see if everything still works, but from
> what I see it seems like it is doing the right thing.  The issue I was
> trying to solve back then did not exist.

OK, please ack when you think it is okay to revert that change.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]