bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#60338: [PATCH] Add option to present server changes as diffs


From: Philip Kaludercic
Subject: bug#60338: [PATCH] Add option to present server changes as diffs
Date: Sun, 11 Jun 2023 21:33:40 +0000

The previous patch couldn't be applied onto master anymore, so I have
adjusted it and merged the user option into 
'eglot-confirm-server-initiated-edits'.

Attachment: 0001-Allow-for-LSP-edits-to-be-generated-as-diffs.patch
Description: Text Data

In addition to that, here is a cheap command that would allow for a
patch to be applied with a single command.  I've bound it to C-c C-x,
but perhaps there is a more intuitive key?

Attachment: 0002-Add-command-to-apply-an-entire-diff-at-once.patch
Description: Text Data

Philip Kaludercic <philipk@posteo.net> writes:

> X-CC-Debbugs: 
>
> I'd like to propose adding an option that makes server modifications by
> Eglot less invasive.  The current behaviour is to make the changes
> directly in a buffer and open the remaining files to make the
> modifications in those as well (?).  If `eglot-use-diffs' is enabled,
> all confirmations are prepared as patches in a pop-up buffer that the
> user can review and apply at will.  To my knowledge there is no general
> `diff-apply-hunk' that will apply all the changes from a buffer, but
> that is a separate issue that can be fixed in a separate patch.
>
> (Note, I'm still testing emacs-29, so the patch was developed on that
> branch.  But it should be applied to master)

-- 
Philip Kaludercic

reply via email to

[Prev in Thread] Current Thread [Next in Thread]