bug#64055: [WIP Patch] Enable editing commit messages - vc-git-modify-change-comment

[Robert Pluim]

>>>>> On Tue, 13 Jun 2023 18:59:24 -0400, Morgan Smith 
>>>>> <Morgan.J.Smith@outlook.com> said:

    Morgan> Please look at this patch.  Ignore the bad commit message for now, 
I'm
    Morgan> trying to figure out how to edit that :P.

    Morgan> I've spent far too long looking at git documentation and source 
code.  I
    Morgan> think this is the best way to enable this feature.  In fact I really
    Morgan> don't think there is another way to implement this feature that 
doesn't
    Morgan> rely on the "autosquash" git feature.

Does 'git commit --amend -m' not work?

    Morgan> I found the hack located in vc-git-modify-change-comment' of setting
    Morgan> "GIT_SEQUENCE_EDITOR=:" on the internet and I don't understand how 
it
    Morgan> works.

    Morgan> Also I'm not really sure what the 'vc-dispatcher-browsing' function 
is
    Morgan> supposed to do but it's getting in my way.  Like are 'diff-mode' 
buffers
    Morgan> a "directory browser buffer"?  I don't understand the intent here.

    Morgan> Also you'll noticed I deleted some comments in vc.el.  That's 
mainly to
    Morgan> highlight them so we can talk about them now.  Is there a good way 
to
    Morgan> stop users from editing remote commits?

You canʼt stop anyone from doing anything on their local system, but I
guess you could check if 'git merge-base' is upstream.

    Morgan> I feel like I should probably just keep working on this and get it 
more
    Morgan> polished and answer some of my own questions before posting here 
but I'm
    Morgan> getting kind of frustrated with this.  I am many hours deep into 
this
    Morgan> problem.

We can be your rubber duck :-)

Robert
--