[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#64017: Wrong conversion from Emacs to Tree-sitter S-expression synta
From: |
Basil Contovounesios |
Subject: |
bug#64017: Wrong conversion from Emacs to Tree-sitter S-expression syntax |
Date: |
Fri, 16 Jun 2023 18:33:28 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Mattias Engdegård [2023-06-16 19:02 +0200] wrote:
> Here is a modification of the treesit manual to teach s-expressions first.
> It's mostly a matter of straightforward substitution.
Generally LGTM, thanks.
> diff --git a/doc/lispref/parsing.texi b/doc/lispref/parsing.texi
> index b0824faaaa2..bd81ee3c535 100644
> --- a/doc/lispref/parsing.texi
> +++ b/doc/lispref/parsing.texi
> @@ -1132,9 +1132,9 @@ Pattern Matching
>
> @defun treesit-query-capture node query &optional beg end node-only
> This function matches patterns in @var{query} within @var{node}.
> -The argument @var{query} can be either a string, a s-expression, or a
> -compiled query object. For now, we focus on the string syntax;
> -s-expression syntax and compiled query are described at the end of the
> +The argument @var{query} can be either a s-expression, a string, or a
> +compiled query object. For now, we focus on the s-expression syntax;
> +string syntax and compiled query are described at the end of the
> section.
I recently tweaked some of these docs in emacs-29, so you may want to
merge into master before respinning your patch.
> @@ -1341,22 +1341,23 @@ Pattern Matching
> @noindent
> tree-sitter only matches arrays where the first element equals to the
> last element. To attach a predicate to a pattern, we need to group
> -them together. A predicate always starts with a @samp{#}. Currently
> -there are three predicates, @code{#equal}, @code{#match}, and
> -@code{#pred}.
> +them together. Currently
> +there are three predicates, @code{:equal}, @code{:match}, and
> +@code{:pred}.
Do you intend to refill the paragraph before merging?
> @itemize
> @item
> -Anchor @samp{.} is written as @code{:anchor}.
> +Anchor @code{:anchor}. is written as @samp{.}
^
Unladen European full stop migrated from eol.
--
Basil
- bug#64017: Wrong conversion from Emacs to Tree-sitter S-expression syntax, Mattias Engdegård, 2023/06/12
- bug#64017: Wrong conversion from Emacs to Tree-sitter S-expression syntax, Yuan Fu, 2023/06/15
- bug#64017: Wrong conversion from Emacs to Tree-sitter S-expression syntax, Mattias Engdegård, 2023/06/16
- bug#64017: Wrong conversion from Emacs to Tree-sitter S-expression syntax, Mattias Engdegård, 2023/06/16
- bug#64017: Wrong conversion from Emacs to Tree-sitter S-expression syntax,
Basil Contovounesios <=
- bug#64017: Wrong conversion from Emacs to Tree-sitter S-expression syntax, Mattias Engdegård, 2023/06/17
- bug#64017: Wrong conversion from Emacs to Tree-sitter S-expression syntax, Eli Zaretskii, 2023/06/17
- bug#64017: Wrong conversion from Emacs to Tree-sitter S-expression syntax, Mattias Engdegård, 2023/06/17
- bug#64017: Wrong conversion from Emacs to Tree-sitter S-expression syntax, Yuan Fu, 2023/06/17
- bug#64017: Wrong conversion from Emacs to Tree-sitter S-expression syntax, Mattias Engdegård, 2023/06/18
- bug#64017: Wrong conversion from Emacs to Tree-sitter S-expression syntax, Yuan Fu, 2023/06/17