bug#64147: 30.0.50; Crash when deleting fullscreen frame on macOS

[Eshel Yaron]

Daniel Martín <mardani29@yahoo.es> writes:

> In ns_free_frame_resources, the frame's window is closed, but the view
> is not removed from the hierarchy, meaning that it could be called by
> AppKit.  That is problematic, because the frame's output_data is
> nullified just a few lines later.
>
> Does the following patch (on top of master) solve the problem?
>
> diff --git a/src/nsterm.m b/src/nsterm.m
> index 3e089cc1ff1..2c0c90e70e1 100644
> --- a/src/nsterm.m
> +++ b/src/nsterm.m
> @@ -1624,7 +1624,7 @@ Hide the window (X11 semantics)
>      [f->output_data.ns->miniimage release];
>  
>    [[view window] close];
> -  [view release];
> +  [view removeFromSuperview];
>  
>    xfree (f->output_data.ns);
>    f->output_data.ns = NULL;

Yes, this seems to solve it, thanks!


-- 
Best,

Eshel