[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#64329: 29.0.92; treesit/fill-paragraph syntax highlighting problem
From: |
Yuan Fu |
Subject: |
bug#64329: 29.0.92; treesit/fill-paragraph syntax highlighting problem |
Date: |
Thu, 29 Jun 2023 11:17:26 -0700 |
> On Jun 28, 2023, at 10:22 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Wed, 28 Jun 2023 17:17:14 -0700
>> Cc: 64329@debbugs.gnu.org,
>> Eli Zaretskii <eliz@gnu.org>
>>
>> Prompted by this, I went over all the functions that calls
>> signal_after_change again, and found two other editfns.c functions that are
>> missing calls to treesit_record_change. Please see the attached patches that
>> follows the previous one. Sorry for the overlook. I believe I’ve found all
>> places that needs to call treesit_record_change now.
>>
>>> Please see the attached patch. Eli, is it more preferable to add a
>>> subroutine in insdel.c that does what "for (i = 0; i < len; i++) *p++ =
>>> tostr[I];” does, plus calling treesit_record_change, and make
>>> subst-char-in-region call that subroutine? (This way editfns.c don’t need
>>> to include treesit.h and call treesit_record_change itself.)
>>
>> Since now there are three functions in editfns.c that needs to call
>> treesit_record_change, we might as well just include treesit.h and call
>> treesit_record_change directly.
>
> Right.
Ok, I've pushed the changes.
Yuan