[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62216: Odd file corruption in clojure mode and emacs 30 HEAD
From: |
Eli Zaretskii |
Subject: |
bug#62216: Odd file corruption in clojure mode and emacs 30 HEAD |
Date: |
Wed, 30 Aug 2023 15:00:59 +0300 |
> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: Jonathon McKitrick <jcm@SDF.ORG>, Eli Zaretskii <eliz@gnu.org>, Paul
> Eggert <eggert@cs.ucla.edu>, 62216@debbugs.gnu.org
> Date: Wed, 30 Aug 2023 10:59:08 +0200
>
> Po Lu <luangruo@yahoo.com> writes:
>
> > Jonathon McKitrick <jcm@SDF.ORG> writes:
> >
> >> What's the best mechanism to log these values in emacs?
> >
> > In this case, printf.
>
> When I add this assumption:
>
> modified src/fileio.c
> @@ -4805,8 +4805,11 @@ DEFUN ("insert-file-contents", Finsert_file_contents,
> Sinsert_file_contents,
>
> /* 'try' is reserved in some compilers (Microsoft C). */
> ptrdiff_t trytry = min (gap_size, READ_BUF_SIZE);
> + ptrdiff_t trytry_old = min (total - inserted, READ_BUF_SIZE);
> if (!NILP (end))
> trytry = min (trytry, total - inserted);
> + if (trytry != trytry_old)
> + abort ();
>
> if (!seekable && NILP (end))
> {
>
> and make bootstrap, temacs aborts.
>
> Can someone tell if this assumption should hold?
You expect READ_BUF_SIZE to never be greater than gap_size?
- bug#62216: Narrowed the issue to one line, (continued)
- bug#62216: Narrowed the issue to one line, Paul Eggert, 2023/08/20
- bug#62216: Narrowed the issue to one line, Jonathon McKitrick, 2023/08/20
- bug#62216: Narrowed the issue to one line, Jonathon McKitrick, 2023/08/22
- bug#62216: Narrowed the issue to one line, Paul Eggert, 2023/08/22
- bug#62216: Narrowed the issue to one line, Eli Zaretskii, 2023/08/22
- bug#62216: Narrowed the issue to one line, Paul Eggert, 2023/08/22
- bug#62216: Narrowed the issue to one line, Jonathon McKitrick, 2023/08/21
- bug#62216: Narrowed the issue to one line, Jonathon McKitrick, 2023/08/21
- bug#62216: Narrowed the issue to one line, Po Lu, 2023/08/21
- bug#62216: Odd file corruption in clojure mode and emacs 30 HEAD, Gerd Möllmann, 2023/08/30
- bug#62216: Odd file corruption in clojure mode and emacs 30 HEAD,
Eli Zaretskii <=
- bug#62216: Odd file corruption in clojure mode and emacs 30 HEAD, Gerd Möllmann, 2023/08/30
- bug#62216: Odd file corruption in clojure mode and emacs 30 HEAD, Jonathon McKitrick, 2023/08/31
- bug#62216: Odd file corruption in clojure mode and emacs 30 HEAD, Eli Zaretskii, 2023/08/31
- bug#62216: Odd file corruption in clojure mode and emacs 30 HEAD, Jonathon McKitrick, 2023/08/31