bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#67357: [PATCH] Fix c-ts-mode block indent when first-siblings are co


From: Yuan Fu
Subject: bug#67357: [PATCH] Fix c-ts-mode block indent when first-siblings are comments
Date: Sun, 10 Dec 2023 17:11:42 -0800
User-agent: Mozilla Thunderbird



On 12/10/23 1:39 AM, Eli Zaretskii wrote:
Date: Sun, 10 Dec 2023 01:09:15 -0800
Cc: noah.v.peart@gmail.com, 67357@debbugs.gnu.org, dmitry@gutov.dev
From: Yuan Fu <casouri@gmail.com>


Ping! Ping!  Yuan, please chime is, as I'm waiting for your comments
before we install on the release branch.

This and other patches for TS-based modes are currently delaying the
release of Emacs 29.2, so please try to be more responsive, okay?

Whoa! Sorry, I just switched to a new email client, and direct CC isn't
highlight as they were before :-( (And admittedly I haven't been
browsing the bug tracker lately.)
OK, but please look also at other bugs and issues where I asked for
your opinions.
Yes, I'm trying to setup something that can prevent this in the future, and there are so many CC's that I missed, apologies!
As for the patch, first of all, thank you, Noah, it's very good. I try
to avoid query matchers since they could be slow, plus the fundamental
problem isn't with comments, IMO. The problem is when the first sibling
isn't on it's own line. (Though in normal C source code, when the first
sibling isn't on its own line, that sibling is usually a comment.)
Anyway, please see my reasoning in the commit message for 08fc6bace20.

I also removed the else_clause rule since it's already added by the
patch for bug#67417, and added another test.
Thanks, but please in the future mention _all_ relevant bug numbers
in the log message, or merge them if appropriate.
I'll keep that in mind.

Yuan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]